-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Improvements to FeatureTestCaseTest #1904
Conversation
@jim-parry I got it working for me in this branch. Does that work for you also? |
testing |
That does fix things :) I have incorporated the changes into my original PR & pushed. Now I can finish the tests, thanks! |
Hmmm - the tests run locally fine as "./phpunit tests/system/Test/", but not as "./phpunit". |
travis-ci is breaking in SQLite3 stuff - not related to this PR as far as I can tell. |
@@ -147,7 +147,7 @@ class CLI | |||
* | |||
* @var string | |||
*/ | |||
protected static $lastWrite; | |||
protected static $lastWrite = 'write'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What were you running into here? Lastwrite should be null before it's used so that an initial call to 'write' will add an empty line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is that the previous unit tests were not looking for that empty line, and hence failed on mmy system. Basically, the previous PR broke that unit test on my system.
These two might have been caused by these changes:
No clue why the sqlite is failing now. Nothing in here should have touched that. |
I have been getting some strange unit testing results with CodeIgniterTest and MigrationRunnerTest for some weeks now. I think it might be time to reclone & reconstruct my local repo :-/ |
Related to #1767, #1692 & possibly #1697