Update Cache RedisHandler to support select database. #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonnieezell
reviewed
Feb 14, 2019
|
|
||
| if (isset($config['database']) && ! $this->redis->select($config['database'])) | ||
| { | ||
| // log_message('error', 'Cache: Redis select database failed.'); |
There was a problem hiding this comment.
This shouldn't be commented out.
There was a problem hiding this comment.
I had commented this out to log an error message.
But in the mean time, I notice only redis->connect will throw an RedisException if connection is failed.
redis->auth will only return a false rather an RedisException if auth is failed.
Should I enable the log for that either?
There was a problem hiding this comment.
Oh, yes, we should definitely be logging all of those situations. Though I've already merged this PR so you'll probably have to make another. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update Cache RedisHandler to support select database.
As this feature already exist in Session RedisHandler
Checklist: