Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

database performance improvement : use foreach() when possible #1530

Merged

Conversation

samsonasik
Copy link
Member

Previously, there are count() and then loop with for(), the foreach actually should already can handle it.

Checklist:

  • Securely signed commits

@samsonasik samsonasik changed the title database performance improment : use foreach() when possible database performance improvement : use foreach() when possible Nov 24, 2018
@lonnieezell
Copy link
Member

Honestly, the performance difference you're going to see here is likely so close as to be non-existent. But this is cleaner, easier to read, and doesn't look like it will break anything so I'm down.

@lonnieezell lonnieezell merged commit 65e1f30 into codeigniter4:develop Nov 26, 2018
@samsonasik samsonasik deleted the db-performance-improvement branch November 27, 2018 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants