Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make name parameter in HTTP\Header mandatory #1164

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

samsonasik
Copy link
Member

if the name is not mandatory, when we create a HTTP\Header and call it as string from __toString(), we will get the ": " value, which seems incorrect as message header.

@lonnieezell
Copy link
Member

Hmm. I was thinking there were some headers that only had a single value but I'm not able to find this now, so I"ll merge this for now with the caveat that if I find something along those lines in the future we might have to re-evaluate.

@lonnieezell lonnieezell merged commit d7ba12a into codeigniter4:develop Aug 19, 2018
@samsonasik samsonasik deleted the name-header-mandatory branch August 19, 2018 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants