Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run session tests in separate processes - fix for #1106 #1128

Merged
merged 10 commits into from
Aug 3, 2018

Conversation

andreifurrnica
Copy link
Contributor

running phpunit tests in separate processes doesn't throw the error from #1106 anymore

@andreifurrnica andreifurrnica changed the title Run session tests in separate processes - fix for #1106 WIP: Run session tests in separate processes - fix for #1106 Aug 1, 2018
@jim-parry
Copy link
Contributor

Hmm - the tests are still broken :(
It could be because the default page output has been reintroduced, commiting the output.

ps contribution commits should be GPG-signed.

@andreifurrnica
Copy link
Contributor Author

and how can that output be disabled? To be honest, I don't understand where is it coming from in this case

@andreifurrnica andreifurrnica changed the title WIP: Run session tests in separate processes - fix for #1106 Run session tests in separate processes - fix for #1106 Aug 2, 2018
@andreifurrnica
Copy link
Contributor Author

Finally, the tests are passing.

The thing is that all the tests that are using the session must run in separate processes and have "preserveGlobalState" disabled.

Please take a look at the changes and approve the request if everything is ok.

PS: probably is a good idea to squash the commits.

@lonnieezell
Copy link
Member

Thanks for this! I was starting to work on the issue Monday night, but I've had a product launch to prepare for today so have been working late the last couple of nights.

While this fixes the issue for testing, I don't know that It fixes it for someone using the app, which is where I had started working on. Assuming the launch goes good today, I'll be able to test my implementation more tonight.

Shouldn't have any conflicts with what you've done here, though, so thanks again!

@lonnieezell lonnieezell merged commit 6efd2b0 into codeigniter4:develop Aug 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants