Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Debug Bar showing before the head tag #2545

Closed
zehferrari opened this issue Feb 13, 2020 · 0 comments
Closed

Bug: Debug Bar showing before the head tag #2545

zehferrari opened this issue Feb 13, 2020 · 0 comments
Assignees
@MGatner
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@zehferrari
Copy link

Direction
We use github issues to track bugs, not for support.
If you have a support question, or a feature request, raise these as threads on our
forum.

Describe the bug
The debug bar scripts are been inserted in the page before the <head> tag

CodeIgniter 4 version
CodeIgniter 4 RC4

Affected module(s)
Everywhere using the Debug

Expected behavior, and steps to reproduce if appropriate
Change the Debug/Toolbar.php line 396 with the code:
str_replace("<head>", $script . "<head>", $response->getBody())

from: $script . "<head>"
to: "<head>".$script

(the $script should come after the head tag)

Context

  • OS: Linux Fedora 30
  • Web server: Nginx 1.16.1
  • PHP version: 7.3.14
@zehferrari zehferrari added the bug Verified issues on the current code behavior or pull requests that will fix them label Feb 13, 2020
@zehferrari zehferrari changed the title Bug: Bug: Debug Bar showing before the head tag Feb 13, 2020
@MGatner MGatner self-assigned this Feb 16, 2020
@MGatner MGatner mentioned this issue Feb 17, 2020
Merged
5 tasks
MGatner added a commit that referenced this issue Feb 17, 2020
@MGatner
Merge pull request #2566 from MGatner/toolbar-head
2e73061 
Move debug toolbar after head tag. Fixes #2545
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MGatner MGatner

Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zehferrari @MGatner