Bug: Spark issue with PHP install location

[yrneh-mi]

Bug?
If PHP is installed to a directory with a space in its name 'php spark serve' returns error: 'C:\Program' is not recognized as an internal or external command,
operable program or batch file.

CodeIgniter 4 version
CodeIgniter 4.0.0.0-rc3

Affected module(s)
Running command 'php spark serve'

Expected behavior, and steps to reproduce if appropriate
Install and configure PHP (any version) to 'C:\Program Files\PHP' (any directory with a space in its name).
Execute command 'php spark serve'.
OR
Execute command '"C:\Program Files\PHP\7.3.10\php.exe" spark serve' (complete php path).

Context

• OS: Windows 10 Pro 64bit
• Web server: N/A
• PHP version: 7.3.10

[lonnieezell]

This is not an issue with spark. It is a Windows/PHP issue. See this SO post for examples of others having issues.

[EdgarEldy]

I have experienced the same problem and it's still not resolved.
Whenever i run php spark serve it returns this error : 'C:\Program' is not recognized as an internal or external command' Any help ?

[MGatner]

That screenshot was very helpful! This appears to be an issue with the call to PHP itself. I think we need to quote our passthru call to the PHP binary here:

		passthru($php . ' -S ' . $host . ':' . $port . ' -t ' . $docroot . ' ' . $rewrite, $status);

Reopening.

[EdgarEldy]

That screenshot was very helpful! This appears to be an issue with the call to PHP itself. I think we need to quote our passthru call to the PHP binary here:

		passthru($php . ' -S ' . $host . ':' . $port . ' -t ' . $docroot . ' ' . $rewrite, $status);

Reopening.

Which file ?

[MGatner]

system/Commands/Server/Serve.php

[EdgarEldy]

Thanks. I fixed it. Don’t forget to fix it also in codeigniter4/framework and all other repository. Sent from Mail<https://go.microsoft.com/fwlink/?LinkId=550986> for Windows 10

…

________________________________ From: MGatner <[email protected]> Sent: Saturday, February 29, 2020 5:00:25 PM To: codeigniter4/CodeIgniter4 <[email protected]> Cc: Edgar MUHAMYANGABO <[email protected]>; Comment <[email protected]> Subject: Re: [codeigniter4/CodeIgniter4] Bug: Spark issue with PHP install location (#2367) system/Commands/Server/Serve.php — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#2367?email_source=notifications&email_token=AGH6I2SBFH3JQQZYM4EC23TRFERITA5CNFSM4JFQXAQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENL4EGY#issuecomment-592953883>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGH6I2WWTY3JRIFLG3LNIYTRFERITANCNFSM4JFQXAQQ>.

[mierol16]

I can't solve this error. Anyone can help?