Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controller filters match too loosely. #2038

Closed
lonnieezell opened this issue Jun 4, 2019 · 0 comments · Fixed by #2039
Closed

Controller filters match too loosely. #2038

lonnieezell opened this issue Jun 4, 2019 · 0 comments · Fixed by #2039
Assignees
@lonnieezell
Labels
bug Verified issues on the current code behavior or pull requests that will fix them

Comments

@lonnieezell
Copy link
Member

See thread in the forum: https://forum.codeigniter.com/thread-73777.html

Basically - we currently do a preg_match without any restrictions to ensure that's ALL that is in the uri when matched, which makes things way too crazy. Need to restrict the match better.
@lonnieezell lonnieezell added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 4, 2019
@lonnieezell lonnieezell added this to the 4.0.0-rc.1 milestone Jun 4, 2019
@lonnieezell lonnieezell self-assigned this Jun 4, 2019
lonnieezell added a commit that referenced this issue Jun 4, 2019
@lonnieezell
Restrict filter matching of uris so they require an exact match. Fixes …
3aa212b 
…#2038
@lonnieezell lonnieezell mentioned this issue Jun 4, 2019
Merged
lonnieezell added a commit that referenced this issue Jun 4, 2019
@lonnieezell
Merge pull request #2039 from codeigniter4/filtermatchfix
0cdf086 
Restrict filter matching of uris so they require an exact match. Fixes #2038
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lonnieezell lonnieezell

Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
1 participant
@lonnieezell