Maybe routes has problem. [setTranslateURIDashes]

[eterv]

I use this config.
setTranslateURIDashes(true)

I think that if I connent 'users/login-process' (dash) then,
should be connected to 'login_process' (underscore) method of 'users' controller.
but contrary to my expectation, just I could see 404 page not found error page.
So, I've checked source.
I think that something important source is missing.

so now I'm using below modified code temporarily.

in: system/Router/Router.php :: autoRoute() function

if ( ! empty($segments))
{
	$this->method = array_shift($segments);
}

    /**
     * Added - BEGIN
     */
    if ($this->collection->shouldTranslateURIDashes()) {
        $this->translateURIDashes = true;
        $this->method = str_replace('-', '_', $this->method);
    }
    /**
     * Added - END
     */

So, could you please check this point?

[bangbangda]

Controller name also needs to be converted.
check this PR. do you think it is okay?

[eterv]

Controller name also needs to be converted.
check this PR. do you think it is okay?

Yes. Exactly!
I checked PR.

but, even if I use $routes->setTranslateURIDashes(true) in app/Config/routes.php file, there is no change.
the $translateURIDashes variable in Router (not Routes) still value is false.
so, I used $this->translateURIDashes = true; in above my example code.

I think that setTranslateURIDashes() function in Router needs to be called somewhere.

could you please check this?

[lonnieezell]

@eterv Just pushed a potential fix, please let me know if it works for you. It is based off of what @bangbangda did, but I think he missed one place.

[eterv]

@lonnieezell thank you for your help and code.

but, I think that need to add below one line code.

in CodeIgniter.php :: tryToRouteIt() method

// Already exist...
$this->router = Services::router($routes);
// A new line
$this->router->setTranslateURIDashes($routes->shouldTranslateURIDashes());

// Already exists...
$path = $this->determinePath();

After modify it then, finally there is no any problem in auto route.

So, could you please consider and test it?

[lonnieezell]

Good catch. Thanks. Fixed now.