Merge pull request #137 from mixinix/develop

Improvement, debug bar Matched Route - Params
codeigniter4 · Jul 1, 2016 · ab76571 · ab76571
2 parents 86ec550 + dd392ba
commit ab76571
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/system/Debug/Toolbar/Collectors/Routes.php b/system/Debug/Toolbar/Collectors/Routes.php
@@ -94,7 +94,20 @@ public function display(): string
 		$output .= "<tr><td>Directory:</td><td>".htmlspecialchars($router->directory())."</td></tr>";
 		$output .= "<tr><td>Controller:</td><td>".htmlspecialchars($router->controllerName())."</td></tr>";
 		$output .= "<tr><td>Method:</td><td>".htmlspecialchars($router->methodName())."</td></tr>";
-		$output .= "<tr><td>Params:</td><td>".print_r($router->params(), true)."</td></tr>";
+
+        	$method = new \ReflectionMethod($router->controllerName(), $router->methodName());
+        	$params = $method->getParameters();
+
+		$output .= "<tr><td>Params:</td><td>".count($router->params())."/".count($params)."</td></tr>";
+
+		foreach($params as $key => $param)
+		{
+			$output .= '<tr class="route-params-item"><td>'.$param->getName()." :</td><td>";
+			$output .= isset($router->params()[$key])
+							? $router->params()[$key]
+							: "&lt;empty&gt;&nbsp| default: ".var_export($param->getDefaultValue(), true);
+			$output .= '</td></tr>';
+		}
 
 		$output .= "</table></tbody>";
 

diff --git a/system/Debug/Toolbar/View/toolbar.css b/system/Debug/Toolbar/View/toolbar.css
@@ -187,4 +187,13 @@ body {
     bottom: 9px;
     border-radius: 3px;
     background-color: #999;
+}
+#debug-bar .route-params,
+#debug-bar .route-params-item {
+    vertical-align: top;
+}
+#debug-bar .route-params-item td:first-child {
+    padding-left: 1em;
+    text-align: right;
+    font-style: italic;
 }