Merge pull request #1159 from samsonasik/reduce-str-replace-parser

reduce str_replace in View/Parser::render()
codeigniter4 · Aug 13, 2018 · 5c0ce8a · 5c0ce8a
2 parents 20d5d02 + b10ddb0
commit 5c0ce8a
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/system/View/Parser.php b/system/View/Parser.php
@@ -129,12 +129,12 @@ public function render(string $view, array $options = null, $saveData = null): s
 			$saveData = $this->config->saveData;
 		}
 
-		$view = str_replace('.php', '', $view) . '.php';
+		$view = str_replace('.php', '', $view);
 
 		// Was it cached?
 		if (isset($options['cache']))
 		{
-			$cacheName = $options['cache_name'] ?: str_replace('.php', '', $view);
+			$cacheName = $options['cache_name'] ?: $view;
 
 			if ($output = cache($cacheName))
 			{
@@ -143,6 +143,7 @@ public function render(string $view, array $options = null, $saveData = null): s
 			}
 		}
 
+               $view = $view . '.php';
 		$file = $this->viewPath . $view;
 
 		if ( ! file_exists($file))