Merge pull request #7962 from kenjis/fix-spark-no-error-msg

fix: spark may not show exceptions or show backtrace as json
codeigniter4 · Oct 10, 2023 · 49d3421 · 49d3421
2 parents 0d94606 + b201faf
commit 49d3421
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/system/CLI/Console.php b/system/CLI/Console.php
@@ -12,6 +12,7 @@
 namespace CodeIgniter\CLI;
 
 use CodeIgniter\CodeIgniter;
+use Config\App;
 use Config\Services;
 use Exception;
 
@@ -31,6 +32,10 @@ class Console
      */
     public function run()
     {
+        // Create CLIRequest
+        $appConfig = config(App::class);
+        Services::createRequest($appConfig, true);
+
         $runner  = Services::commands();
         $params  = array_merge(CLI::getSegments(), CLI::getOptions());
         $params  = $this->parseParamsForHelpOption($params);

diff --git a/user_guide_src/source/changelogs/v4.4.2.rst b/user_guide_src/source/changelogs/v4.4.2.rst
@@ -38,6 +38,8 @@ Bugs Fixed
 
 - **CodeIgniter:** Fixed a bug that returned "200 OK" response status code when
   Page Not Found.
+- **Spark:** Fixed a bug that caused spark to not display exceptions in the
+  production mode or to display backtrace in json when an exception occurred.
 
 See the repo's
 `CHANGELOG.md <https://github.com/codeigniter4/CodeIgniter4/blob/develop/CHANGELOG.md>`_