Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requires static from deeper level must be included if requested. see MCOMPILER-481 #106

Merged
merged 6 commits into from
Jan 31, 2022
Merged

requires static from deeper level must be included if requested. see MCOMPILER-481 #106

merged 6 commits into from
Jan 31, 2022

Conversation

olamy
Copy link
Member

@olamy olamy commented Jan 20, 2022

Signed-off-by: Olivier Lamy [email protected]

@olamy olamy marked this pull request as ready for review January 26, 2022 07:14
@olamy olamy changed the title fix issues including requires static. see MCOMPILER-481 requires static from deeper level must be included if requested. see MCOMPILER-481 Jan 26, 2022
@olamy olamy requested a review from rfscholte January 26, 2022 07:21
@olamy olamy added the bug label Jan 26, 2022
rfscholte
rfscholte reviewed Jan 26, 2022
View reviewed changes
Copy link
Member

@rfscholte rfscholte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I came to the same conclusion: we need an extra parameter.
And I'm very glad that you didn't had to change any of the existing tests.
I think the current includeStatic parameter is not a valid name anymore, looks more like an abuse of isRootModule.

plexus-java/src/main/java/org/codehaus/plexus/languages/java/jpms/LocationManager.java Show resolved Hide resolved
@olamy
improve variable naming
e304fc6 
Signed-off-by: Olivier Lamy <[email protected]>
@olamy olamy requested a review from rfscholte January 31, 2022 07:06
@rfscholte
Copy link
Member

There's still something wrong in the selectRequires method, looks like there's a mixup of boolean values. I'll try to rewrite that part.

@rfscholte
Copy link
Member

I think there was a bug in one one the lasts tests too, exposes while rewriting the selectRequires() method. I think this should be it.

@olamy olamy merged commit 86e0436 into master Jan 31, 2022
@olamy olamy deleted the MCOMPILER-481-requires-static-included branch January 31, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfscholte rfscholte Awaiting requested review from rfscholte

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olamy @rfscholte