Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CR-23223 rename and graduate argo-cd-sync step from incubating #692

Merged
merged 6 commits into from
Apr 17, 2024

Conversation

vadim-kharin-codefresh
Copy link
Contributor

What

Why

Notes

@@ -3,7 +3,7 @@ metadata:
name: argo-cd-sync
version: 1.4.4
isPublic: true
description: Syncs Argo CD apps managed by our GitOps Runtimes
description: The step is deprecated. Use gitops-argocd-sync instead. Syncs Argo CD apps managed by our GitOps Runtimes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not enough, put the warning in the README.md please

sources:
- 'https://github.com/codefresh-io/steps/tree/master/graduated/gitops-argocd-sync'
stage: incubating
maintainers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add us as maintainers

description: Syncs Argo CD apps managed by our GitOps Runtimes
sources:
- 'https://github.com/codefresh-io/steps/tree/master/graduated/gitops-argocd-sync'
stage: incubating
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong stage

@vadim-kharin-codefresh vadim-kharin-codefresh merged commit 1b98a3a into master Apr 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants