feat: create both rootless and rootfull images #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ATGardner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
copied the current dockerfile into Dockerfile.rootless
removed rootless lines from Dockerfile
also updated node-exporter, and kubectl, and got kubectl from bitnami image instead of using curl.
Why
we need to have rootless and rootfull dind-volume-utils, to match the rootless/full state of the dind pod
Notes
Labels
Assign the following labels to the PR:
security- to trigger image scanning in CI buildPR Comments
Add the following comments to the PR:
/e2e- to trigger E2E build