Fix metrics being cached for removed node-pools #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes node pools or instance groups (GKE) are removed or replaced. But the metrics exporter keeps reporting numbers for those removed node pools. We need to clear Gauges on every status poll before setting labels and values to make sure removed node-pools are no longer reported. Also add some CLI args support.
adidenko
force-pushed
the
fix_caching_of_removed_instance_groups
branch
from
f34b901 to
b575358
Compare
wiktorkisielewski
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes node pools or instance groups (GKE) are removed or replaced.
But the metrics exporter keeps reporting numbers for those removed node
pools. We need to clear Gauges on every status poll before setting
labels and values to make sure removed node-pools are no longer reported.
Also add some CLI args support.