feat: update cli to retrieve promotion commits for product release steps #758
Conversation
cmd/commands/product-release.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("failed to get product releases: %w", err) | ||
| if strings.Contains(err.Error(), "Cannot query field \\\"promotionCommits\\\" on type \\\"ProductReleaseStep\\\".") { | ||
| log.G().Warn("codefresh version v0.13.4 or older detected. Using v0.13.4 query which excludes promotionCommits.") |
There was a problem hiding this comment.
I added this warning, but now I'm not sure as if there are customers/internal users using this cli command in automation the extra log line of output would make it fail.
I can also just make it fallback silently?
There was a problem hiding this comment.
i think that should be ok, showing a warning, but falling back to previous query.
this way they will know that something may work better if they upgrade their platform.
cmd/commands/product-release.go
Outdated
| } | ||
| ` | ||
|
|
||
| const v0_13_4_query = ` |
There was a problem hiding this comment.
I'll update the specific version references once I've merged the argo-platform changes.
|
I've tested this against g.codefresh while it runs a pre v1.3120.1 version and it correctly logs a warning and displays the results without the applications property. |
What
Adding promotion commits to product release steps if the version of codefresh is compatible. I've added a fall back in case the cli is connected to an old version of codefresh (on prem).
Why
A customer wanted to know the commit created by promotions for each step of a product release for each application. See Jira ticket for details.
Notes
Jira: https://codefresh-io.atlassian.net/browse/CR-25720