Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: leave the validation of setHeaderRoute to the plugin when plug… #303

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

denis-codefresh
Copy link

…ins is not empty. (argoproj#2898)

chore: leave the validation of setHeaderRoute to the plugin if plugins not empty.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

andyliuliming and others added 2 commits July 1, 2024 16:40
…ins is not empty. (argoproj#2898)

chore: leave the validation of setHeaderRoute to the plugin if plugins not empty.

Signed-off-by: Liming Liu <[email protected]>
Co-authored-by: Ubuntu <andliu@devbox.5xpt1tfa54mehhcinhsnwwrpve.ix.internal.cloudapp.net>
Copy link

github-actions bot commented Jul 2, 2024

Go Published Test Results

2 068 tests   2 068 ✅  2m 47s ⏱️
  118 suites      0 💤
    1 files        0 ❌

Results for commit 594f87a.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 2, 2024

E2E Tests Published Test Results

  4 files    4 suites   3h 23m 20s ⏱️
103 tests  93 ✅  6 💤 4 ❌
416 runs  388 ✅ 24 💤 4 ❌

For more details on these failures, see this check.

Results for commit 594f87a.

@denis-codefresh denis-codefresh merged commit 791f6b3 into release-1.6 Jul 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants