fix: acr controller crashes when it is newly created app #1238

Workflow file for this run

.github/workflows/ci-build.yaml at 032b524

	name: Integration tests
	on:
	push:
	branches:
	# - 'master'
	- 'release-*'
	- '!release-1.4'
	- '!release-1.5'
	pull_request:
	branches:
	# - 'master'
	- 'release-*' # Codefresh change instead of `master`

	env:
	# Golang version to use across CI steps
	GOLANG_VERSION: '1.22'

	concurrency:
	group: ${{ github.workflow }}-${{ github.ref }}
	cancel-in-progress: true

	permissions:
	contents: read

	jobs:
	changes:
	runs-on: ubuntu-latest
	outputs:
	backend: ${{ steps.filter.outputs.backend_any_changed }}
	frontend: ${{ steps.filter.outputs.frontend_any_changed }}
	docs: ${{ steps.filter.outputs.docs_any_changed }}
	steps:
	- uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- uses: tj-actions/changed-files@d6babd6899969df1a11d14c368283ea4436bca78 # v44.5.2
	id: filter
	with:
	# Any file which is not under docs/, ui/ or is not a markdown file is counted as a backend file
	files_yaml: \|
	backend:
	- '!ui/**'
	- '!**.md'
	- '!*/.md'
	- '!docs/**'
	frontend:
	- 'ui/**'
	- Dockerfile
	docs:
	- 'docs/**'
	check-go:
	name: Ensure Go modules synchronicity
	if: ${{ needs.changes.outputs.backend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- changes
	steps:
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Setup Golang
	uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
	with:
	go-version: ${{ env.GOLANG_VERSION }}
	- name: Download all Go modules
	run: \|
	go mod download
	- name: Check for tidiness of go.mod and go.sum
	run: \|
	go mod tidy
	git diff --exit-code -- .

	build-go:
	name: Build & cache Go code
	if: ${{ needs.changes.outputs.backend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- changes
	steps:
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Setup Golang
	uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
	with:
	go-version: ${{ env.GOLANG_VERSION }}
	- name: Restore go build cache
	uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
	with:
	path: ~/.cache/go-build
	key: ${{ runner.os }}-go-build-v1-${{ github.run_id }}
	- name: Download all Go modules
	run: \|
	go mod download
	- name: Compile all packages
	run: make build-local

	lint-go:
	name: Lint Go code
	if: ${{ needs.changes.outputs.backend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- changes
	steps:
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Setup Golang
	uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
	with:
	go-version: ${{ env.GOLANG_VERSION }}
	- name: Run golangci-lint
	uses: golangci/golangci-lint-action@a4f60bb28d35aeee14e6880718e0c85ff1882e64 # v6.0.1
	with:
	version: v1.58.2
	args: --verbose

	test-go:
	name: Run unit tests for Go packages
	if: ${{ needs.changes.outputs.backend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- build-go
	- changes
	env:
	GITHUB_TOKEN: ${{ secrets.E2E_TEST_GITHUB_TOKEN \|\| secrets.GITHUB_TOKEN }}
	GITLAB_TOKEN: ${{ secrets.E2E_TEST_GITLAB_TOKEN }}
	steps:
	- name: Create checkout directory
	run: mkdir -p ~/go/src/github.com/argoproj
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Create symlink in GOPATH
	run: ln -s $(pwd) ~/go/src/github.com/argoproj/argo-cd
	- name: Setup Golang
	uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
	with:
	go-version: ${{ env.GOLANG_VERSION }}
	- name: Install required packages
	run: \|
	sudo apt-get install git -y
	- name: Switch to temporal branch so we re-attach head
	run: \|
	git switch -c temporal-pr-branch
	git status
	- name: Fetch complete history for blame information
	run: \|
	git fetch --prune --no-tags --depth=1 origin +refs/heads/:refs/remotes/origin/
	- name: Add ~/go/bin to PATH
	run: \|
	echo "/home/runner/go/bin" >> $GITHUB_PATH
	- name: Add /usr/local/bin to PATH
	run: \|
	echo "/usr/local/bin" >> $GITHUB_PATH
	- name: Restore go build cache
	uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
	with:
	path: ~/.cache/go-build
	key: ${{ runner.os }}-go-build-v1-${{ github.run_id }}
	- name: Install all tools required for building & testing
	run: \|
	make install-test-tools-local
	- name: Setup git username and email
	run: \|
	git config --global user.name "John Doe"
	git config --global user.email "[email protected]"
	- name: Download and vendor all required packages
	run: \|
	go mod download
	- name: Run all unit tests
	run: make test-local
	- name: Generate test results artifacts
	uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
	with:
	name: test-results
	path: test-results

	test-go-race:
	name: Run unit tests with -race for Go packages
	if: ${{ needs.changes.outputs.backend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- build-go
	- changes
	env:
	GITHUB_TOKEN: ${{ secrets.E2E_TEST_GITHUB_TOKEN \|\| secrets.GITHUB_TOKEN }}
	GITLAB_TOKEN: ${{ secrets.E2E_TEST_GITLAB_TOKEN }}
	steps:
	- name: Create checkout directory
	run: mkdir -p ~/go/src/github.com/argoproj
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Create symlink in GOPATH
	run: ln -s $(pwd) ~/go/src/github.com/argoproj/argo-cd
	- name: Setup Golang
	uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
	with:
	go-version: ${{ env.GOLANG_VERSION }}
	- name: Install required packages
	run: \|
	sudo apt-get install git -y
	- name: Switch to temporal branch so we re-attach head
	run: \|
	git switch -c temporal-pr-branch
	git status
	- name: Fetch complete history for blame information
	run: \|
	git fetch --prune --no-tags --depth=1 origin +refs/heads/:refs/remotes/origin/
	- name: Add ~/go/bin to PATH
	run: \|
	echo "/home/runner/go/bin" >> $GITHUB_PATH
	- name: Add /usr/local/bin to PATH
	run: \|
	echo "/usr/local/bin" >> $GITHUB_PATH
	- name: Restore go build cache
	uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
	with:
	path: ~/.cache/go-build
	key: ${{ runner.os }}-go-build-v1-${{ github.run_id }}
	- name: Install all tools required for building & testing
	run: \|
	make install-test-tools-local
	- name: Setup git username and email
	run: \|
	git config --global user.name "John Doe"
	git config --global user.email "[email protected]"
	- name: Download and vendor all required packages
	run: \|
	go mod download
	- name: Run all unit tests
	run: make test-race-local
	- name: Generate test results artifacts
	uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
	with:
	name: race-results
	path: test-results/

	codegen:
	name: Check changes to generated code
	if: ${{ needs.changes.outputs.backend == 'true' \|\| needs.changes.outputs.docs == 'true'}}
	runs-on: ubuntu-22.04
	needs:
	- changes
	steps:
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Setup Golang
	uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
	with:
	go-version: ${{ env.GOLANG_VERSION }}
	- name: Create symlink in GOPATH
	run: \|
	mkdir -p ~/go/src/github.com/argoproj
	cp -a ../argo-cd ~/go/src/github.com/argoproj
	- name: Add ~/go/bin to PATH
	run: \|
	echo "/home/runner/go/bin" >> $GITHUB_PATH
	- name: Add /usr/local/bin to PATH
	run: \|
	echo "/usr/local/bin" >> $GITHUB_PATH
	- name: Download & vendor dependencies
	run: \|
	# We need to vendor go modules for codegen yet
	go mod download
	go mod vendor -v
	working-directory: /home/runner/go/src/github.com/argoproj/argo-cd
	- name: Install toolchain for codegen
	run: \|
	make install-codegen-tools-local
	make install-go-tools-local
	working-directory: /home/runner/go/src/github.com/argoproj/argo-cd
	- name: Run codegen
	run: \|
	set -x
	export GOPATH=$(go env GOPATH)
	git checkout -- go.mod go.sum
	make codegen-local
	working-directory: /home/runner/go/src/github.com/argoproj/argo-cd
	- name: Check nothing has changed
	run: \|
	set -xo pipefail
	git diff --exit-code -- . ':!go.sum' ':!go.mod' ':!assets/swagger.json' \| tee codegen.patch
	working-directory: /home/runner/go/src/github.com/argoproj/argo-cd

	build-ui:
	name: Build, test & lint UI code
	# We run UI logic for backend changes so that we have a complete set of coverage documents to send to codecov.
	if: ${{ needs.changes.outputs.backend == 'true' \|\| needs.changes.outputs.frontend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- changes
	steps:
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	- name: Setup NodeJS
	uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
	with:
	node-version: '21.6.1'
	- name: Restore node dependency cache
	id: cache-dependencies
	uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
	with:
	path: ui/node_modules
	key: ${{ runner.os }}-node-dep-v2-${{ hashFiles('**/yarn.lock') }}
	- name: Install node dependencies
	run: \|
	cd ui && yarn install --frozen-lockfile --ignore-optional --non-interactive
	- name: Build UI code
	run: \|
	yarn test
	yarn build
	env:
	NODE_ENV: production
	NODE_ONLINE_ENV: online
	HOST_ARCH: amd64
	working-directory: ui/
	- name: Run ESLint
	run: yarn lint
	working-directory: ui/

	analyze:
	name: Process & analyze test artifacts
	if: ${{ needs.changes.outputs.backend == 'true' \|\| needs.changes.outputs.frontend == 'true' }}
	runs-on: ubuntu-22.04
	needs:
	- test-go
	- build-ui
	- changes
	env:
	sonar_secret: ${{ secrets.SONAR_TOKEN }}
	steps:
	- name: Checkout code
	uses: actions/checkout@8410ad0602e1e429cee44a835ae9f77f654a6694 # v4.0.0
	with:
	fetch-depth: 0
	- name: Restore node dependency cache
	id: cache-dependencies
	uses: actions/cache@0c45773b623bea8c8e75f6c82b208c3cf94ea4f9 # v4.0.2
	with:
	path: ui/node_modules
	key: ${{ runner.os }}-node-dep-v2-${{ hashFiles('**/yarn.lock') }}
	- name: Remove other node_modules directory
	run: \|
	rm -rf ui/node_modules/argo-ui/node_modules
	- name: Get unit test code coverage
	uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
	with:
	name: test-results
	path: test-results
	- name: Upload code coverage information to codecov.io
	uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
	with:
	file: coverage.out

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: acr controller crashes when it is newly created app #1238

Workflow file

fix: acr controller crashes when it is newly created app #1238

Jobs

Run details

Workflow file for this run