Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign valid links to left nav header links #469

Merged
merged 1 commit into from
Dec 20, 2020
Merged

Conversation

Chris-Boe
Copy link
Contributor

What issue is this solving?

Closes #436

Any helpful knowledge/context for the reviewer?

Is a npm install necessary? nope
Any special requirements to test? Just click the two header links Add and Manage and they should take you to the first sub-link under the headers

Please make sure you've attempted to meet the following coding standards

  • Code builds successfully
  • Code has been tested and does not produce errors
  • Code is readable and formatted
  • There isn't any unnecessary commented-out code
  • There aren't any unnecessary commits or files changed (shouldn't touch the /stashed folder unless the issue requests it)

If you're having trouble meeting this criteria, feel free to reach out on Slack for help!

@Chris-Boe Chris-Boe self-assigned this Dec 10, 2020
@htharker42 htharker42 temporarily deployed to dwellingly-p-issue436-1w3ppmdh December 10, 2020 04:09 Inactive
@DaveTrost
Copy link
Member

Looks good! Nice and simple

Copy link
Member

@DaveTrost DaveTrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ship it"

@Chris-Boe Chris-Boe merged commit 9151414 into development Dec 20, 2020
@Chris-Boe Chris-Boe deleted the issue436 branch December 20, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar update for header links: "Add New" and "Manage"
3 participants