Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 662/fix failing tests #667

Merged
merged 9 commits into from
Aug 14, 2024
Merged

Issue 662/fix failing tests #667

merged 9 commits into from
Aug 14, 2024

Conversation

andycwilliams
Copy link
Member

This PR:

Resolves the following incomplete tests in issue 662:

1. ContactListTableDesktop
2. ContactListTableMobile
3. Messages

@andycwilliams andycwilliams added the MVP Issues related to MVP label Aug 7, 2024
@andycwilliams andycwilliams self-assigned this Aug 7, 2024
leekahung
leekahung requested changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! It looks like it's just those two remaining tests in Signup.test.jsx that was failing.

Think I can approve after that is patched up.

test/pages/Signup.test.jsx Show resolved Hide resolved
leekahung
leekahung approved these changes Aug 14, 2024
View reviewed changes
Copy link
Contributor

@leekahung leekahung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just re-did the tests with the changes, looks great! 🚀

@andycwilliams andycwilliams merged commit db4cade into Development Aug 14, 2024
3 checks passed
@andycwilliams andycwilliams deleted the issue-662/fix-failing-tests branch August 14, 2024 01:04
@andycwilliams andycwilliams mentioned this pull request Aug 14, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leekahung leekahung leekahung approved these changes

@AJSterner AJSterner Awaiting requested review from AJSterner

@joshua-cornett joshua-cornett Awaiting requested review from joshua-cornett

Assignees

@andycwilliams andycwilliams

Labels
MVP Issues related to MVP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andycwilliams @leekahung