Cleanup/connection_manager_api

[worksofliam]

Changes

Replaces raw access of connections setting and password context with a ConnectionManager namespace.

How to test this PR

1. Ensure the same test cases pass
2. Try out the extension as normal
3. Confirm debug still works
4. When editing connection settings or login settings, ensure the sort button is disabled.

Checklist

• have tested my change
• have created one or more test cases
• updated relevant documentation
• Remove any/all console.logs I added
• have added myself to the contributors' list in CONTRIBUTING.md

[sebjulliand]

Nice cleanup @worksofliam ! Way cleaner than the raw accesses we used to do. I love it!
See the few comments I made, mostly code cleanup.

One thing to consider: since we update by index, there is a use case where the data can be saved on the wrong index:

• Open the settings of a connection and keep it opened
• Sort the connections browser
• Save the opened settings

Since the indexes were changed while sorting, the index kept by the settings editor is not the right one anymore.
I admit it's an edge case...but if I thought of it, someone else will.
So maybe we should set a context value while the webview is opened to prevent the sort and rename actions from being executed.

[worksofliam]

@sebjulliand Let me look into how to solve this problem. Should have a fix for it by the end of the week. Thanks for your review!

[worksofliam]

@sebjulliand Sorry this took SO long. I went ahead and used withContext around the UI logic to disable the buttons. Check it out and let me know - thanks!

[sebjulliand]

@worksofliam I'll fix a small issue here with withContext; in the meantime, how about adding that brilliant use of it to disable the buttons and disable code-for-ibmi.connectTo, code-for-ibmi.connectToAndReload, code-for-ibmi.renameConnection, code-for-ibmi.deleteConnection as well? WDYT?

[sebjulliand]

@worksofliam works like a charm! Brilliant cleanup!
Just see my last comment about disabling more commands to avoid potential issues and then we'll be good to go!

[worksofliam]

@sebjulliand I went ahead with your suggestion, and some other commands also. Thanks!

[sebjulliand]

Not sure about disabling "code-for-ibmi.showAdditionalSettings" and "code-for-ibmi.showLoginSettings"; it doesn't seem to be risky to open multiple editors (sorry...)

[worksofliam]

@sebjulliand Updated!

[sebjulliand]

Approved and merged! 😎