Add warning messages

Signed-off-by: worksofliam <[email protected]>
codefori · Jun 3, 2024 · 9c266cd · 9c266cd
1 parent b7652bd
commit 9c266cd
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 4 deletions.
diff --git a/src/locale/ids/en.json b/src/locale/ids/en.json
@@ -365,6 +365,10 @@
   "sandbox.noPassword": "Connection to {0} ended as no password was provided.",
   "save": "Save",
   "service.certificate.exists": "Remote service certificate exists",
+  "uriOpen.openError": "Error opening file",
+  "uriOpen.hostMismatch": "A file on another host is trying to be opened. Do you want to open on the current connection instead?",
+  "uriOpen.missingPath": "The provided URI is missing the path attribute.",
+  "uriOpen.noConnection": "You must have an active connection to open a file.",
   "shortcut": "shortcut",
   "size": "Size",
   "skip": "Skip",

diff --git a/src/uri/index.ts b/src/uri/index.ts
@@ -21,8 +21,14 @@ export async function registerUriHandler(context: ExtensionContext) {
                 if (queryData.host) {
                   const host = Array.isArray(queryData.host) ? queryData.host[0] : queryData.host;
                   if (host !== connection.currentHost) {
-                    // TODO: host does not match requested host, do you still want to open?
-                    return;
+                    const chosen = await window.showInformationMessage(t(`uriOpen.openError`), {
+                      detail: t(`uriOpen.hostMismatch`),
+                      modal: true
+                    }, `Open`);
+
+                    if (chosen !== `Open`) {
+                      return;
+                    }
                   }
                 }
 
@@ -31,12 +37,13 @@ export async function registerUriHandler(context: ExtensionContext) {
                   commands.executeCommand(`code-for-ibmi.openEditable`, path);
                 }
               } else {
-                // TODO: error message: missing path
+                window.showWarningMessage(t(`uriOpen.missingPath`));
               }
             } else {
-              // TODO: error message: no connection
+              window.showWarningMessage(t(`uriOpen.noConnection`));
             }
             break;
+
           case `/connect`:
             if (connection === undefined) {
               const save = queryData.save === `true`;