-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed errors from development console #91
Conversation
@Abhishek-kumar09 Please review this PR and also look into soft shadows theming options. I was not able to figure it out. But commenting it out removed the error from the console. |
Hey @rizwan2000rm I mean I was also debugging the errors how did you find out the specific location to the errors from the chunk files. |
Github, rebase |
@Abhishek-kumar09 I think that didn't work. Do you want me to rebase to a single commit ? |
I'm sorry, I have confirmed with my fork again with latest changes, I don't see any of these errors. I have resolved them. All of those saying "X cannot appear as descendant of p" were due to the following line at line 111, src/pages/CoursePageViewWithVideo/index.js
|
Looks good, Ok to merge once CI passed |
Issue Number
fixes #88
Describe the changes you've made
Removed all the development console errors. Turns out most of them were from a single line as a whole component was passed inside a tag which resulted in many errors.
Describe if there is any unusual behavior (Any Warning) of your code(Write
NA
if there isn't)Failed prop type: Material-UI: This elevation 4 is not implemented
The error above is caused by soft Shadows in Material UI theming options. I have commented it out for now, as I don't understand what those options means maybe someone can help me with that.
**Additional context **
There are still 2 errors in the console which are due to some dependencies installed.
[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021.
Not yet released will be fixed in a react update soon.
Issue: facebook/create-react-app#10474
PR: facebook/react#20831
componentWillReceiveProps has been renamed, and is not recommended for use
Resolved and published in Alpha
PR: oliviertassinari/react-swipeable-views#616
Checklist