Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed errors from development console #91

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

rizwan2000rm
Copy link
Contributor

@rizwan2000rm rizwan2000rm commented Mar 14, 2021

Issue Number

fixes #88

Describe the changes you've made

Removed all the development console errors. Turns out most of them were from a single line as a whole component was passed inside a tag which resulted in many errors.

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Failed prop type: Material-UI: This elevation 4 is not implemented

The error above is caused by soft Shadows in Material UI theming options. I have commented it out for now, as I don't understand what those options means maybe someone can help me with that.

**Additional context **

There are still 2 errors in the console which are due to some dependencies installed.

[Deprecation] SharedArrayBuffer will require cross-origin isolation as of M91, around May 2021.

Not yet released will be fixed in a react update soon.
Issue: facebook/create-react-app#10474
PR: facebook/react#20831

componentWillReceiveProps has been renamed, and is not recommended for use
Resolved and published in Alpha
PR: oliviertassinari/react-swipeable-views#616

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • The title of my pull request is a short description of the requested changes.

@rizwan2000rm
Copy link
Contributor Author

@Abhishek-kumar09 Please review this PR and also look into soft shadows theming options. I was not able to figure it out. But commenting it out removed the error from the console.

@ADRE9
Copy link
Contributor

ADRE9 commented Mar 14, 2021

Hey @rizwan2000rm I mean I was also debugging the errors how did you find out the specific location to the errors from the chunk files.

src/theme/index.js Outdated Show resolved Hide resolved
@Abhishek-kumar09
Copy link
Contributor

Github, rebase

@rizwan2000rm
Copy link
Contributor Author

@Abhishek-kumar09 I think that didn't work. Do you want me to rebase to a single commit ?

@Abhishek-kumar09
Copy link
Contributor

Abhishek-kumar09 commented Mar 18, 2021

I am seeing that you havn't added anything for removing console errors, I could just see the eslint fixes done with npm run lint:fix. I could see many errors in the console.
Screenshot from 2021-03-18 13-09-09

@rizwan2000rm
Copy link
Contributor Author

I'm sorry, I have confirmed with my fork again with latest changes, I don't see any of these errors. I have resolved them. All of those saying "X cannot appear as descendant of p" were due to the following line
{value === index && ( <Box> <Typography>{children}</Typography> </Box> )}

at line 111, src/pages/CoursePageViewWithVideo/index.js

{value === index && <Box>{children}</Box>}
which were resolved just by changing it to this. Typography uses p as a default tag which was wrapped around all those tags, hence resulting in so many errors. All other errors are due to some dependencies installed look above messge for details.

Logs

@Abhishek-kumar09
Copy link
Contributor

Looks good, Ok to merge once CI passed

@Abhishek-kumar09 Abhishek-kumar09 merged commit ba4b06c into codeforcauseorg:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove all errors from development console
3 participants