Sc 412 stepper accessibility #5485
Conversation
|
Heroku app: https://gyr-review-app-5485-a91408490be0.herokuapp.com/ |
| @@ -4,40 +4,40 @@ | |||
| describe "Flow" do | |||
| it "Flow has not changed" do | |||
| expect(Navigation::StateFileAzQuestionNavigation::FLOW).to eq([ | |||
| StateFile::Questions::EligibleController, | |||
There was a problem hiding this comment.
Auto-linter changed indentation to match line 6. Happy to change it back before merging if this bothers folks.
There was a problem hiding this comment.
oof i am sorry to report it does bother me 🙈; would you mind just assigning the array to a variable and putting the variable in the expectation? 🙏
There was a problem hiding this comment.
No worries! (It was bugging me too haha)
config/locales/es.yml
Outdated
| section_4: Transferir tus datos | ||
| section_5: Completa tu declaración de impuestos estatales | ||
| section_6: Envía tus impuestos estatales | ||
| step_description: 'Paso %{current_step} de %{total_steps}: ' |
There was a problem hiding this comment.
[pebble] Our conversation about translation + Damian's video make me think that we can maybe keep using the word "section"/"sección" here and in the en version? Then it's less of a change
There was a problem hiding this comment.
Good point! This is going through CFA approval with Anu right now, I will bring up this option as an alternative!
| @@ -58,7 +58,7 @@ | |||
| it "returns the correct progress" do | |||
| progress = Navigation::StateFileAzQuestionNavigation.get_progress(StateFile::Questions::FederalInfoController) | |||
| expect(progress).to eq({ | |||
| title: "Section 5: Complete your state tax return", | |||
| title: "Complete your state tax return", | |||
There was a problem hiding this comment.
[microscopic dust] I wonder if it's worth changing "title" to something like "caption" to avoid confusion with the title attribute or page title. Not adamant about this opinion though
Link to pivotal/JIRA issue
This issue is public! Highly recommend that both CFA and NJ reviewers check out the ticket.
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
tag so screen readers can convey the same information to users
How to test?
Validated that stepper component attribute does not have title element
Validated that step description now includes total step count
Use any persona, navigate to after DF import to display stepper component
Step through tax flow and verify that stepper component behaves correctly
Download NVDA on Windows state laptop, check heroku deploy and validate that screen reader issue no longer exists.
Screenshots (for visual changes)
SC.412.-.before.video.win.mp4
SC.412.-.before.video.mac.mov
Video to come