Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip noitfy job on unsubscribed #5462

Merged
merged 3 commits into from
Feb 6, 2025
Merged

Conversation

squanto
Copy link
Contributor

@squanto squanto commented Jan 28, 2025

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-1682

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

Skip the SendStillProcessingNoticeJob when sms notifications are turned off

Copy link

Heroku app: https://gyr-review-app-5462-79e7fa9815a3.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5462 (optionally add --tail)

Copy link
Member

@mpidcock mpidcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a cleanup suggestion

app/jobs/state_file/send_still_processing_notice_job.rb Outdated Show resolved Hide resolved
@squanto squanto merged commit ff7e488 into main Feb 6, 2025
7 checks passed
@squanto squanto deleted the FYST-1682-24hr-notif-on-reject branch February 6, 2025 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants