Issue 58: Bump ruby version to 2.4.2 #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes codeforamerica#58. 2.4.2 is the latest version of ruby [supported by Heroku](https://devcenter.heroku.com/articles/ruby-support#supported-runtimes). The current version is causing deploys of this app to Heroku to fail. This also updates various dependencies in the lockfile using `bundle update #{name}` because of issues related to newer versions of ruby. - `json` [⚠](ruby/json#286) - `safe_yaml` [⚠](dtao/safe_yaml#67) - `webmock` [⚠] (bblimke/webmock#683) For folks that have this checked out locally, I also had to `brew install --force` to force an up to date build of `http_parse.rb`, which was throwing `Symbol not found: _rb_cFixnum`. Finally, this updates petharbor cassette to include URL encoded quotes - this is probably just an internal change to `URI.encode_www_form`.
mshenfield
force-pushed
the
issue-58-bump-ruby-to-fix-deploy-to-heroku
branch
from
d247848 to
48badf8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #58. 2.4.2 is the latest version of ruby supported by Heroku. The current version is causing deploys of this app to Heroku to fail.
This also updates various dependencies in the lockfile using
bundle update #{name}because of issues related to newer versions of ruby.json⚠safe_yaml⚠webmock⚠For folks that have this checked out locally, I also had to
brew install --forceto force an up-to-date build ofhttp_parse.rb, which was throwingSymbol not found: _rb_cFixnum.Finally, this updates the petharbor cassette URI to include URL encoded single quotes, which were causing a failing test. The change in encoding was probably just an internal change to
URI.encode_www_formfrom ruby 2.1 to 2.4.