THE001-90 handle exception for foreign key constraints #42
Conversation
…te-record' into feature/THE001-90-errors-on-delete-record
…te-record' into feature/THE001-90-errors-on-delete-record
| $resourceClass = get_class($model); | ||
|
|
||
| $filamentResource = collect(Filament::getResources()) | ||
| ->first(function ($filamentResource) use ($resourceClass) { |
There was a problem hiding this comment.
Kan je hier geen arrow function gebruiken? fn () => ...
- typing voorzien, is
$filamentResourceeen string, array, Model?
| return $filamentResource::getModel() === $resourceClass; | ||
| }); | ||
|
|
||
| if (! $filamentResource) { |
There was a problem hiding this comment.
Waarom die if als je toch gewoon $filamentResource returned daaronder?
| @@ -28,3 +30,38 @@ function is_image_with_dimensions(string $extension): bool | |||
| return in_array($extension, config('filament-media-library.extensions.image', [])) && $extension !== 'svg'; | |||
| } | |||
| } | |||
|
|
|||
| if (! function_exists('get_resource_by_model')) { | |||
There was a problem hiding this comment.
Filament heeft hier zelf een functie voor: https://filamentphp.com/api/3.x/Filament/FilamentManager.html#method_getModelResource
| protected static function formatFailedRecords(Collection $failedRecords): string | ||
| { | ||
| return collect($failedRecords) | ||
| ->map(function ($relatedRecords) { |
There was a problem hiding this comment.
Je kan hier ook fn () => ... gebruiken
| public function getRegisteredModelsWithFields(): Collection | ||
| { | ||
| return $this->map(function ($formats, $model) { | ||
| $fields = $formats->map(function (Format $format) { |
There was a problem hiding this comment.
Je kan hier ook fn (Format $format) => $format->column() gebruiken
| ->unique() | ||
| ->values(); | ||
|
|
||
| return (object) [ |
There was a problem hiding this comment.
Waarom return je hier een object en geen array? Array is makkelijker te typehinten dan een object.
| $columns = Schema::getColumnListing($table); | ||
|
|
||
| $model->fields->each(function ($field) use ($modelInstance, $record, $columns, &$records) { | ||
| if (! in_array($field, $columns)) { |
There was a problem hiding this comment.
Kan dit verplaatst worden naar een ->filter op de model->fields?
No description provided.