Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatibility with firebase > 8.0.0 #185

Open
hgrewa opened this issue Dec 19, 2020 · 8 comments
Open

compatibility with firebase > 8.0.0 #185

hgrewa opened this issue Dec 19, 2020 · 8 comments

Comments

@hgrewa
Copy link

hgrewa commented Dec 19, 2020

Any idea of how to handle the breaking change that comes with firebase 8.0.0 onward

Before 8.0.0
import * as firebase from 'firebase/app'

After 8.0.0
import firebase from 'firebase/app'

Adding geofirex to a new angular application is throwing errors like

Error: node_modules/geofirex/dist/client.d.ts:5:18 - error TS2694: Namespace '"..../node_modules/firebase/index"' has no exported member 'firestore'.

--> geopoint: fb.firestore.GeoPoint;

I tried adding "allowSyntheticDefaultImports": true to tsconfig, but that does not address the issue
Is there a workaround?

@jasonc624
Copy link

Need this too.

@dylangolow
Copy link

Any update on this coming?

@lucdef
Copy link

lucdef commented Mar 22, 2021

Repo seem dead.
I tried to modify the source but i got an error when i execute run build:

Created bundle index.cjs.js: 23.75 kB → 6.8 kB (gzip)
Created bundle index.esm.js: 23.56 kB → 6.74 kB (gzip)
(!) Unresolved dependencies
https://rollupjs.org/guide/en/#warning-treating-module-as-external-dependency
firebase/firestore (imported by src\client.ts, src\query.ts)
created dist/index.cjs.js, dist/index.esm.js in 1.3s

@tzvc
Copy link

tzvc commented Apr 1, 2021

I created a pull request to support firebase ^8.0.0 feel free to upvote it #204

@selemessaied
Copy link

I created a pull request to support firebase ^8.0.0 feel free to upvote it #204

How can i use your pull request in my project?

It's amazing what you did, i upvoted!

@tusharvikky
Copy link

Any update here?

@fergardi
Copy link

Is this project still maintained?

@mattostanik
Copy link

It has been several years since the last comment and it appears this repo is no longer maintained, but I came across this discussion while trying to get geofirex to work with a newer version of Firebase.

If it helps anyone else who also comes across this, there appears to be a fork of the package that has been updated to work with newer Firebase versions.

https://www.npmjs.com/package/@thetsf/geofirex

Thank you to the author of the fork!

sue445 added a commit to sue445/primap that referenced this issue Jan 4, 2024
sue445 added a commit to sue445/primap that referenced this issue Jan 4, 2024
sue445 added a commit to sue445/primap that referenced this issue Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants