feat: Only show auto-activate toggle for admins when on enterprise cloud plan #3690
Conversation
spalmurray-codecov
force-pushed
the
spalmurray/hide-auto-activate-enterprise-non-admins
branch
from
f40451e to
43db784
Compare
Bundle ReportChanges will increase total bundle size by 223 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3690 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 824 824
Lines 14811 14814 +3
Branches 4199 4208 +9
=======================================
+ Hits 14632 14635 +3
Misses 170 170
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3690 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 824 824
Lines 14811 14814 +3
Branches 4199 4208 +9
=======================================
+ Hits 14632 14635 +3
Misses 170 170
Partials 9 9
Continue to review full report in Codecov by Sentry.
|
| const showAutoActivate = | ||
| !isUndefined(planAutoActivate) && | ||
| !planData?.plan?.isTrialPlan && | ||
| planData?.plan?.trialStatus !== TrialStatuses.ONGOING | ||
| planData?.plan?.trialStatus !== TrialStatuses.ONGOING && | ||
| !(planData?.plan?.isEnterprisePlan && !ownerData.isAdmin) // only show for admins on enterprise cloud plans |
There was a problem hiding this comment.
This is a monster of a conditional 😭
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
spalmurray-codecov
deleted the
spalmurray/hide-auto-activate-enterprise-non-admins
branch
Title. Adds another data fetch hook call, but I think this is guaranteed to be a local cache hit as this same hook is used in a parent component.
Closes codecov/engineering-team#3201