-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New flake aggregates hook #3389
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3389 +/- ##
=====================================================
Coverage ? 98.97%
=====================================================
Files ? 808
Lines ? 14283
Branches ? 3938
=====================================================
Hits ? 14136
Misses ? 136
Partials ? 11
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## tests-analytics-v2 #3389 +/- ##
=====================================================
Coverage ? 98.97%
=====================================================
Files ? 808
Lines ? 14283
Branches ? 3933
=====================================================
Hits ? 14136
Misses ? 136
Partials ? 11
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3389 +/- ##
=====================================================
Coverage ? 98.97%
=====================================================
Files ? 808
Lines ? 14283
Branches ? 3933
=====================================================
Hits ? 14136
Misses ? 136
Partials ? 11
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3389 +/- ##
=====================================================
Coverage ? 98.98%
=====================================================
Files ? 808
Lines ? 14276
Branches ? 3932
=====================================================
Hits ? 14131
Misses ? 134
Partials ? 11
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Description
Needed for the plan based hook
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.