Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: New flake aggregates hook #3389

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Conversation

RulaKhaled
Copy link
Contributor

Description

Needed for the plan based hook

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (tests-analytics-v2@6817eb9). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 77.77% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                  Coverage Diff                  @@
##             tests-analytics-v2    #3389   +/-   ##
=====================================================
  Coverage                      ?   98.97%           
=====================================================
  Files                         ?      808           
  Lines                         ?    14283           
  Branches                      ?     3938           
=====================================================
  Hits                          ?    14136           
  Misses                        ?      136           
  Partials                      ?       11           
Files with missing lines Coverage Δ
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 88.00% <77.77%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 100.00% <0.00%> (?)
Pages 98.59% <0.00%> (?)
Services 99.45% <0.00%> (?)
Shared 99.80% <0.00%> (?)
UI 99.10% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6817eb9...96e03bf. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (tests-analytics-v2@6817eb9). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 77.77% 2 Missing ⚠️

Impacted file tree graph

@@                  Coverage Diff                  @@
##             tests-analytics-v2    #3389   +/-   ##
=====================================================
  Coverage                      ?   98.97%           
=====================================================
  Files                         ?      808           
  Lines                         ?    14283           
  Branches                      ?     3933           
=====================================================
  Hits                          ?    14136           
  Misses                        ?      136           
  Partials                      ?       11           
Files with missing lines Coverage Δ
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 88.00% <77.77%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 100.00% <0.00%> (?)
Pages 98.59% <0.00%> (?)
Services 99.45% <0.00%> (?)
Shared 99.80% <0.00%> (?)
UI 99.10% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6817eb9...96e03bf. Read the comment docs.

Copy link

codecov-public-qa bot commented Oct 13, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (tests-analytics-v2@6817eb9). Learn more about missing BASE report.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             tests-analytics-v2    #3389   +/-   ##
=====================================================
  Coverage                      ?   98.97%           
=====================================================
  Files                         ?      808           
  Lines                         ?    14283           
  Branches                      ?     3933           
=====================================================
  Hits                          ?    14136           
  Misses                        ?      136           
  Partials                      ?       11           
Files Coverage Δ
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 88.00% <77.77%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 100.00% <0.00%> (?)
Pages 98.59% <0.00%> (?)
Services 99.45% <0.00%> (?)
Shared 99.80% <0.00%> (?)
UI 99.10% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6817eb9...96e03bf. Read the comment docs.

@codecov-notifications
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                  @@
##             tests-analytics-v2    #3389   +/-   ##
=====================================================
  Coverage                      ?   98.98%           
=====================================================
  Files                         ?      808           
  Lines                         ?    14276           
  Branches                      ?     3932           
=====================================================
  Hits                          ?    14131           
  Misses                        ?      134           
  Partials                      ?       11           
Files with missing lines Coverage Δ
...ge/hooks/useFlakeAggregates/useFlakeAggregates.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <0.00%> (?)
Layouts 100.00% <0.00%> (?)
Pages 98.62% <0.00%> (?)
Services 99.45% <0.00%> (?)
Shared 99.80% <0.00%> (?)
UI 99.10% <0.00%> (?)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6817eb9...7de4e14. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 13, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
7de4e14 Sun, 13 Oct 2024 12:32:49 GMT Expired Expired
96e03bf Sun, 13 Oct 2024 13:23:42 GMT Cloud Enterprise

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@RulaKhaled RulaKhaled merged commit 1053b2e into tests-analytics-v2 Oct 14, 2024
50 checks passed
@RulaKhaled RulaKhaled deleted the new-flake-aggregtes branch October 14, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants