Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Glue in pass/fail/skip params into tooltip via test results query #3384

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR glues in the pass fail and skip counts from the test results query to the tooltip shown when you hover the flake rate field.
A minor refactor had to be done when generating the test results "values" to show on the table because multiple values from the query are being populated onto a single column.

I basically just moved over that component logic to the column and had the column render the value itself instead of having it on the column.

Screenshots

Screenshot 2024-10-10 at 4 52 37 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Oct 11, 2024

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
aa81658 Fri, 11 Oct 2024 00:02:42 GMT Expired Expired
1d9083c Fri, 11 Oct 2024 16:40:46 GMT Cloud Enterprise

@@ -21,6 +21,9 @@ const TestResultSchema = z.object({
failureRate: z.number().nullable(),
flakeRate: z.number().nullable(),
avgDuration: z.number().nullable(),
totalFailCount: z.number(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to confirm, these cannot be null right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's right!

Copy link
Contributor

@RulaKhaled RulaKhaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's goo

@codecov-staging
Copy link

Bundle Report

Changes will increase total bundle size by 3.35kB (0.05%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-array-push 6.15MB 3.35kB (0.05%) ⬆️

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (4a58220) to head (1d9083c).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               51.85%   98.98%   +47.12%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3929     3929               
=======================================================
+ Hits                     7393    14112     +6719     
+ Misses                   6041      134     -5907     
+ Partials                  823       11      -812     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) ⬆️

... and 385 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+84.10%) ⬆️
Services 99.45% <ø> (+1.23%) ⬆️
Shared 99.80% <ø> (+1.89%) ⬆️
UI 99.10% <ø> (+0.55%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (4a58220) to head (1d9083c).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               41.75%   98.98%   +57.22%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3924     3929        +5     
=======================================================
+ Hits                     5953    14112     +8159     
+ Misses                   7278      134     -7144     
+ Partials                 1026       11     -1015     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) ⬆️

... and 457 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+87.39%) ⬆️
Services 99.45% <ø> (+41.71%) ⬆️
Shared 99.80% <ø> (+1.89%) ⬆️
UI 99.10% <ø> (+0.55%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.98%. Comparing base (4a58220) to head (1d9083c).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               41.75%   98.98%   +57.22%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3924     3929        +5     
=======================================================
+ Hits                     5953    14112     +8159     
+ Misses                   7278      134     -7144     
+ Partials                 1026       11     -1015     
Files Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) ⬆️

... and 457 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+87.39%) ⬆️
Services 99.45% <ø> (+41.71%) ⬆️
Shared 99.80% <ø> (+1.89%) ⬆️
UI 99.10% <ø> (+0.55%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           tests-analytics-v2    #3384       +/-   ##
=======================================================
+ Coverage               41.75%   98.98%   +57.22%     
=======================================================
  Files                     807      807               
  Lines                   14257    14257               
  Branches                 3924     3924               
=======================================================
+ Hits                     5953    14112     +8159     
+ Misses                   7278      134     -7144     
+ Partials                 1026       11     -1015     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 98.70% <100.00%> (+98.70%) ⬆️
...ailedTestsPage/SelectorSection/SelectorSection.tsx 0.00% <ø> (ø)
.../useInfiniteTestResults/useInfiniteTestResults.tsx 100.00% <ø> (+100.00%) ⬆️

... and 457 files with indirect coverage changes

Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 100.00% <ø> (ø)
Pages 98.62% <100.00%> (+87.39%) ⬆️
Services 99.45% <ø> (+41.71%) ⬆️
Shared 99.80% <ø> (+1.89%) ⬆️
UI 99.10% <ø> (+0.55%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a58220...1d9083c. Read the comment docs.

Copy link

codecov bot commented Oct 11, 2024

Bundle Report

Changes will increase total bundle size by 411 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.15MB 411 bytes (0.01%) ⬆️

@ajay-sentry ajay-sentry merged commit 6817eb9 into tests-analytics-v2 Oct 11, 2024
59 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/tooltip-updates branch October 11, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants