-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Glue in pass/fail/skip params into tooltip via test results query #3384
Conversation
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
@@ -21,6 +21,9 @@ const TestResultSchema = z.object({ | |||
failureRate: z.number().nullable(), | |||
flakeRate: z.number().nullable(), | |||
avgDuration: z.number().nullable(), | |||
totalFailCount: z.number(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to confirm, these cannot be null right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's right!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's goo
Bundle ReportChanges will increase total bundle size by 3.35kB (0.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3384 +/- ##
=======================================================
+ Coverage 51.85% 98.98% +47.12%
=======================================================
Files 807 807
Lines 14257 14257
Branches 3929 3929
=======================================================
+ Hits 7393 14112 +6719
+ Misses 6041 134 -5907
+ Partials 823 11 -812
... and 385 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3384 +/- ##
=======================================================
+ Coverage 41.75% 98.98% +57.22%
=======================================================
Files 807 807
Lines 14257 14257
Branches 3924 3929 +5
=======================================================
+ Hits 5953 14112 +8159
+ Misses 7278 134 -7144
+ Partials 1026 11 -1015
... and 457 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3384 +/- ##
=======================================================
+ Coverage 41.75% 98.98% +57.22%
=======================================================
Files 807 807
Lines 14257 14257
Branches 3924 3929 +5
=======================================================
+ Hits 5953 14112 +8159
+ Misses 7278 134 -7144
+ Partials 1026 11 -1015
... and 457 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3384 +/- ##
=======================================================
+ Coverage 41.75% 98.98% +57.22%
=======================================================
Files 807 807
Lines 14257 14257
Branches 3924 3924
=======================================================
+ Hits 5953 14112 +8159
+ Misses 7278 134 -7144
+ Partials 1026 11 -1015
... and 457 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 411 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Description
This PR glues in the pass fail and skip counts from the test results query to the tooltip shown when you hover the flake rate field.
A minor refactor had to be done when generating the test results "values" to show on the table because multiple values from the query are being populated onto a single column.
I basically just moved over that component logic to the column and had the column render the value itself instead of having it on the column.
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.