Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tooltip and correct styling to flake rate column header #3221

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

ajay-sentry
Copy link
Contributor

Description

This PR aims to fix the styling issue on the flake rate tooltip, and adds the copy and tooltip aspect to the column as well

Screenshots

Screenshot 2024-09-19 at 4 02 33 PM

Link to Sample Entry

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Sep 19, 2024

Bundle Report

Changes will increase total bundle size by 74 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-array-push 6.02MB 74 bytes (0.0%) ⬆️

@codecov-qa
Copy link

codecov-qa bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (aa8fa23) to head (1a54818).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3221      +/-   ##
======================================================
+ Coverage               97.68%   97.91%   +0.22%     
======================================================
  Files                     931      934       +3     
  Lines                   14521    14531      +10     
  Branches                 3889     3888       -1     
======================================================
+ Hits                    14185    14228      +43     
+ Misses                    328      298      -30     
+ Partials                    8        5       -3     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 52.94% <100.00%> (+52.94%) ⬆️

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.46% <100.00%> (+0.20%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8fa23...1a54818. Read the comment docs.

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (aa8fa23) to head (1a54818).
Report is 1 commits behind head on tests-analytics-v2.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@                    Coverage Diff                     @@
##           tests-analytics-v2      #3221        +/-   ##
==========================================================
+ Coverage             97.68000   97.91000   +0.23000     
==========================================================
  Files                     931        934         +3     
  Lines                   14521      14531        +10     
  Branches                 3942       3969        +27     
==========================================================
+ Hits                    14185      14228        +43     
+ Misses                    328        298        -30     
+ Partials                    8          5         -3     
Files with missing lines Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 52.94% <100.00%> (+52.94%) ⬆️

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.46% <100.00%> (+0.20%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8fa23...1a54818. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3221      +/-   ##
======================================================
+ Coverage               97.68%   97.91%   +0.22%     
======================================================
  Files                     931      934       +3     
  Lines                   14521    14531      +10     
  Branches                 3969     3888      -81     
======================================================
+ Hits                    14185    14228      +43     
+ Misses                    328      298      -30     
+ Partials                    8        5       -3     
Files Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 52.94% <100.00%> (+52.94%) ⬆️

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.46% <100.00%> (+0.20%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8fa23...1a54818. Read the comment docs.

Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.91%. Comparing base (aa8fa23) to head (1a54818).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           tests-analytics-v2    #3221      +/-   ##
======================================================
+ Coverage               97.68%   97.91%   +0.22%     
======================================================
  Files                     931      934       +3     
  Lines                   14521    14531      +10     
  Branches                 3942     3942              
======================================================
+ Hits                    14185    14228      +43     
+ Misses                    328      298      -30     
+ Partials                    8        5       -3     
Files Coverage Δ
...ledTestsPage/FailedTestsTable/FailedTestsTable.tsx 100.00% <ø> (ø)
.../FailedTestsPage/MetricsSection/MetricsSection.tsx 52.94% <100.00%> (+52.94%) ⬆️

... and 21 files with indirect coverage changes

Components Coverage Δ
Assets 53.48% <ø> (-0.18%) ⬇️
Layouts 98.87% <ø> (+1.49%) ⬆️
Pages 98.46% <100.00%> (+0.20%) ⬆️
Services 99.44% <ø> (+0.03%) ⬆️
Shared 99.65% <ø> (+0.06%) ⬆️
UI 94.57% <ø> (+0.47%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8fa23...1a54818. Read the comment docs.

@codecov-releaser
Copy link
Contributor

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
1a54818 Thu, 19 Sep 2024 23:08:50 GMT Cloud Enterprise

@ajay-sentry ajay-sentry merged commit 555e411 into tests-analytics-v2 Sep 20, 2024
59 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/quick-icon-fix branch September 20, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants