-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add tooltip and correct styling to flake rate column header #3221
Conversation
Bundle ReportChanges will increase total bundle size by 74 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3221 +/- ##
======================================================
+ Coverage 97.68% 97.91% +0.22%
======================================================
Files 931 934 +3
Lines 14521 14531 +10
Branches 3889 3888 -1
======================================================
+ Hits 14185 14228 +43
+ Misses 328 298 -30
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## tests-analytics-v2 #3221 +/- ##
==========================================================
+ Coverage 97.68000 97.91000 +0.23000
==========================================================
Files 931 934 +3
Lines 14521 14531 +10
Branches 3942 3969 +27
==========================================================
+ Hits 14185 14228 +43
+ Misses 328 298 -30
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3221 +/- ##
======================================================
+ Coverage 97.68% 97.91% +0.22%
======================================================
Files 931 934 +3
Lines 14521 14531 +10
Branches 3969 3888 -81
======================================================
+ Hits 14185 14228 +43
+ Misses 328 298 -30
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## tests-analytics-v2 #3221 +/- ##
======================================================
+ Coverage 97.68% 97.91% +0.22%
======================================================
Files 931 934 +3
Lines 14521 14531 +10
Branches 3942 3942
======================================================
+ Hits 14185 14228 +43
+ Misses 328 298 -30
+ Partials 8 5 -3
... and 21 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Description
This PR aims to fix the styling issue on the flake rate tooltip, and adds the copy and tooltip aspect to the column as well
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.