Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

회원 기본 API #39

Merged
merged 2 commits into from
Oct 3, 2016
Merged

회원 기본 API #39

merged 2 commits into from
Oct 3, 2016

Conversation

loustler
Copy link
Contributor

@loustler loustler commented Oct 2, 2016

회원 기본 API

회원쪽만 작성하였고, 소셜은 진행 예정

소셜 진행 방식에 대해 고민 중

  • toString() override 제거
  • Service Layer에서 point control
  • DTO Constructor overloading
  • @PrePersist 제거 후 Service Layer에서 처리
  • 접근제어자 protected에서 private로 수정
  • Member domain Social List를 mappedBy로 수정

- 회원 기본 API
- Service Layer CRUD(only member)
-Controller Layer
- import 수정
- protected -> private 로 수정
-  삭제
@loustler loustler added this to the Sprint 4 milestone Oct 2, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-4.9%) to 17.931% when pulling a0be091 on feature/member-api into 2a08a84 on develop.

@loustler
Copy link
Contributor Author

loustler commented Oct 2, 2016

커버리지가 왜 떨어졌는 지 모르겠네요;;

이상 없으면 내일 10시에 Merge하겠습니다.

Copy link
Contributor Author

@loustler loustler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverage가 왜 떨어졌는 지 모르겠지만

차후에 올리도록 하겠습니다.

@changhwa
Copy link
Member

changhwa commented Oct 2, 2016

커버리지는 천천히 하시죠 ㅎㅎ

@loustler loustler merged commit db5077d into develop Oct 3, 2016
@loustler loustler mentioned this pull request Oct 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants