Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle rejection promise #219

Merged
merged 1 commit into from
Jul 2, 2023

Conversation

kobenguyent
Copy link
Contributor

@kobenguyent kobenguyent commented Dec 23, 2022

Resolve codeceptjs/CodeceptJS#3547
Handling the rejection promise nicely

tth~$npm run codeceptjs:ui

> [email protected] codeceptjs:ui
> codecept-ui --app

(node:33202) UnhandledPromiseRejectionWarning: Error: Config file /Users/trung-thanh/Desktop/create-codeceptjs-fun/codecept.conf.js does not exist. Execute 'codeceptjs init' to create config
    at Function.load (/Users/trung-thanh/Desktop/create-codeceptjs-fun/node_modules/codeceptjs/lib/config.js:85:17)
    at CodeceptjsFactory.create (/Users/trung-thanh/Desktop/create-codeceptjs-fun/node_modules/@codeceptjs/ui/lib/model/codeceptjs-factory.js:73:12)
    at Object.<anonymous> (/Users/trung-thanh/Desktop/create-codeceptjs-fun/node_modules/@codeceptjs/ui/bin/codecept-ui.js:22:19)
    at Module._compile (internal/modules/cjs/loader.js:1085:14)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1114:10)
    at Module.load (internal/modules/cjs/loader.js:950:32)
    at Function.Module._load (internal/modules/cjs/loader.js:790:12)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:76:12)
    at internal/main/run_main_module.js:17:47
(Use `node --trace-warnings ...` to show where the warning was created)
(node:33202) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 2)
(node:33202) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

@Arhell Arhell requested a review from DavertMik February 20, 2023 00:09
@DavertMik DavertMik merged commit d6d5337 into codeceptjs:master Jul 2, 2023
Copy link

github-actions bot commented Feb 8, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Init error with TypeScript
3 participants