Spring: support all media-types for consumes #58
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In Spring, we require the usage of
@RequestBody
annotation before we actually check forconsumes
in@RequestMapping
(or any variation of that). This is quite limiting because@RequestBody
only supportsapplication/json
andapplication/xml
media-type.For example, it is currently impossible to use
mutlipart/form-data
media type.Solution
Only check for
@RequestBody
in case there is noconsumes
annotation already provided inRequestMapping
.Potential improvements
We could make it a little more smart and set it to
multipart/form-data
in case we use@RequestPart
or one of the parameter if of typeMultipartFile
. I honestly think this is more of an edge case and probably it's not worth it to add this extra complexity, but let me know what you think :)