Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icons to ToolWindows (using ImageMoniker) #482 #665

Merged
merged 1 commit into from
Aug 11, 2019
Merged

Add icons to ToolWindows (using ImageMoniker) #482 #665

merged 1 commit into from
Aug 11, 2019

Conversation

Diermeier
Copy link
Contributor

Supporting the two tab-icons for the ToolWindows "BuildProgressToolWindow.cs" and "SpadeToolWindow.cs" by using the imagemanifest way descriped here: https://docs.microsoft.com/en-us/visualstudio/extensibility/internals/manifest-from-resources?view=vs-2019

This pull request targets the issue #482. Small tool windows do not show the icon.
My personal reason for supporting was because I use the plugin "Iconizer"
(https://marketplace.visualstudio.com/items?itemName=OlegTarasov.VisualStudioIconizerforVisualStudio15).

But CodeMaid not supports an icon for that plugin.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@codecadwallader codecadwallader self-assigned this Jul 27, 2019
@codecadwallader
Copy link
Owner

Cool, thanks for putting this together! I'm not familiar with ImageMoniker's so I'll have to read up a bit.

@codecadwallader
Copy link
Owner

Looks good to me, thanks again! :)

@codecadwallader codecadwallader merged commit d995d99 into codecadwallader:master Aug 11, 2019
@codecadwallader codecadwallader added this to the v11.1 milestone Aug 11, 2019
codecadwallader added a commit that referenced this pull request Aug 11, 2019

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants