Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project file (.csproj) cleanup #541

Merged
merged 3 commits into from
Apr 22, 2018
Merged

Conversation

heku
Copy link
Contributor

@heku heku commented Apr 12, 2018

Hi, I made a few changes to .csproj to make it looks better/simpler, feel free to let me know if you have any question.

  1. Remove useless/outdated elements in .csproj
  2. Move start program settings into .csproj and remove .user

Copy link
Owner

@codecadwallader codecadwallader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup! A number of those properties are probably left over from when CodeMaid was built as an MSI package (before VSIX became a standard). I did have one question about the DeployExtension property but otherwise looks good to me.

@@ -46,7 +29,6 @@
<ErrorReport>prompt</ErrorReport>
<WarningLevel>4</WarningLevel>
<Prefer32Bit>false</Prefer32Bit>
<DeployExtension>True</DeployExtension>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure, but I thought these statements were required for Visual Studio to deploy the extension to the experimental instance on build?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I double check and can confirm that its default value for the setting is True, this can be validated on the project properties page | VSIX | Deploy VSIX content to experimental instance for debugging. But I have no problem to revert them back as your preference.

@codecadwallader
Copy link
Owner

Looks good to me, thanks!

@codecadwallader codecadwallader merged commit 29ab94f into codecadwallader:master Apr 22, 2018
@heku heku deleted the csproj branch May 3, 2018 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants