Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to override safety checks #268

Closed
bjorndavis opened this issue Apr 8, 2016 · 6 comments
Closed

Add ability to override safety checks #268

bjorndavis opened this issue Apr 8, 2016 · 6 comments
Assignees
@codecadwallader
Labels
enhancement feature: reorganizing resolved
Milestone
v10.1

Comments

@bjorndavis
Copy link

Environment

  • Visual Studio version: 2013
  • CodeMaid version: 10.0.72
  • Code language: C#

Description

Currently, CodeMaid disables the re-organize function if the file contains any pre-processor conditionals/directives. This should be an be an option that is off by default and allows overriding the safety checks. Thanks!

Related issue:
#239
@codecadwallader
Copy link
Owner

Thanks for splitting this out.

@bjorndavis
Copy link
Author

No prob - I looked into fixing it myself, but unfortunately I don't think I'll be of much help here.

@codecadwallader
Copy link
Owner

Thanks for taking a look, I appreciate that. I can see you're pretty passionate about it so I'll knock it out.

@codecadwallader codecadwallader self-assigned this Apr 8, 2016
@codecadwallader codecadwallader added this to the v10.1 milestone Apr 8, 2016
codecadwallader added a commit that referenced this issue Apr 9, 2016
@codecadwallader
#268: Add an option to prompt the user about whether or not reorganiz…
7a9db45 
…ation should run in the presence of preprocessor conditionals. Follows pattern of cleanup external files.
codecadwallader added a commit that referenced this issue Apr 9, 2016
@codecadwallader
#227 #255 #268: Change commands that have expensive availability chec…
abe3c0f 
…ks to remain enabled, deferring availability checks to execution time.
@codecadwallader
Copy link
Owner

I've implemented this request as a new option as well as a user prompt when detected.

Can you please test the latest CI build (10.0.81 or higher) available here: http://vsixgallery.com/extension/4c82e17d-927e-42d2-8460-b473ac7df316/

@bjorndavis
Copy link
Author

Ok I had some time to test this in 10.0.82 - looks like it's working well. Thanks!

@codecadwallader
Copy link
Owner

Cool, thanks for confirming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codecadwallader codecadwallader

Labels
enhancement feature: reorganizing resolved
Projects
None yet
Milestone
v10.1
Development

No branches or pull requests
2 participants
@codecadwallader @bjorndavis