Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add macos support #73

Merged
merged 4 commits into from
May 15, 2023
Merged

feature: add macos support #73

merged 4 commits into from
May 15, 2023

Conversation

osugikoji
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Add support for macOS

@osugikoji osugikoji self-assigned this May 12, 2023
@osugikoji osugikoji requested a review from kikoso as a code owner May 12, 2023 15:43
@osugikoji osugikoji marked this pull request as draft May 12, 2023 16:23
@kikoso
Copy link
Contributor

kikoso commented May 12, 2023

This looks great! It seems to work on an M1, I wonder if we will be having issues on an Intel machine.

@osugikoji osugikoji marked this pull request as ready for review May 12, 2023 20:22
@osugikoji
Copy link
Contributor Author

This looks great! It seems to work on an M1, I wonder if we will be having issues on an Intel machine.

@kikoso Hi Enrique, I had to change the SPM plugin because the previous one we were using did not support MacOSArm64 architecture. The new plugin is now working well on my M1 machine. I believe it will also work on Intel chips.

@osugikoji osugikoji merged commit e30386c into main May 15, 2023
@osugikoji osugikoji deleted the feature/add-macos-support branch June 2, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants