Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GA test workflow #25

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Added GA test workflow #25

merged 3 commits into from
Feb 15, 2023

Conversation

kikoso
Copy link
Contributor

@kikoso kikoso commented Feb 15, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Added Test workflow to be referred from README

💡 Motivation and Context

This PR adds a test workshop that can later show the testing badge on the README file

@osugikoji
Copy link
Contributor

osugikoji commented Feb 15, 2023

@kikoso The project already has the Kover plugin from Jetbrains set up and running on main CI. Kover is a tool that can help you measure code coverage, much like Jacoco. In our main CI, there is a job that uploads the coverage report in the codecov. Do you think it makes sense to keep both running?

@kikoso
Copy link
Contributor Author

kikoso commented Feb 15, 2023

@kikoso The project already has the Kover plugin from Jetbrains set up and running on main CI. Kover is a tool that can help you measure code coverage, much like Jacoco. In our main CI, there is a job that uploads the coverage report in the codecov. Do you think it makes sense to keep both running?

Let's go for Kover instead!

@kikoso kikoso merged commit 53ec77c into main Feb 15, 2023
@osugikoji osugikoji deleted the feature/added_test_action branch June 2, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants