Skip to content

Commit

Permalink
Fix app so it can be released to the play store
Browse files Browse the repository at this point in the history
To release the app to the Google play store,
'fastlane android beta_internal' needs to work.

The following fixes were made:
 - Update build.gradle to not apply sentry.gradle as it's causing a
   bad sentry url error (note: it will be fixed later)
 - Remove references to react-native-audio and react-native-video
 - Remove references to com.tkporter.sendsms
 - Remove superfluous permissions
  • Loading branch information
chico committed Jan 27, 2019
1 parent a02b098 commit 0f795fa
Show file tree
Hide file tree
Showing 5 changed files with 3 additions and 18 deletions.
4 changes: 1 addition & 3 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ project.ext.react = [
]

apply from: "../../node_modules/react-native/react.gradle"
apply from: "../../node_modules/react-native-sentry/sentry.gradle"
// apply from: "../../node_modules/react-native-sentry/sentry.gradle" // TODO getting bad sentry url

// See https://github.com/luggit/react-native-config#setup
apply from: project(':react-native-config').projectDir.getPath() + "/dotenv.gradle"
Expand Down Expand Up @@ -173,8 +173,6 @@ dependencies {
}
implementation project(':react-native-version-number')
implementation project(':react-native-splash-screen')
implementation project(':react-native-audio')
implementation project(':react-native-video')
implementation project(':react-native-config')
implementation project(':react-native-i18n')
implementation project(':react-native-vector-icons')
Expand Down
7 changes: 2 additions & 5 deletions android/app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<!-- versionCode and versionName set in gradle.properties -->
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
<manifest xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools"
package="com.codeandrobots"
android:versionCode="1"
android:versionName="1.0.0">
Expand All @@ -9,10 +9,7 @@
<uses-permission android:name="android.permission.VIBRATE" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
<uses-permission android:name="android.permission.SYSTEM_ALERT_WINDOW"/>
<uses-permission android:name="android.permission.RECORD_AUDIO" />
<uses-permission android:name="android.permission.READ_PROFILE" />
<uses-permission android:name="android.permission.READ_CONTACTS" />
<uses-permission android:name="android.permission.READ_SMS" />
<uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove" />

<uses-sdk
android:minSdkVersion="16"
Expand Down
2 changes: 0 additions & 2 deletions android/app/src/main/java/com/codeandrobots/MainActivity.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
import org.devio.rn.splashscreen.SplashScreen;

import android.content.Intent;
import com.tkporter.sendsms.SendSMSPackage;

public class MainActivity extends ReactActivity {

Expand All @@ -28,6 +27,5 @@ protected String getMainComponentName() {
@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
super.onActivityResult(requestCode, resultCode, data);
SendSMSPackage.getInstance().onActivityResult(requestCode, resultCode, data);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
import io.invertase.firebase.notifications.RNFirebaseNotificationsPackage;
import com.apsl.versionnumber.RNVersionNumberPackage;
import org.devio.rn.splashscreen.SplashScreenReactPackage;
import com.rnim.rn.audio.ReactNativeAudioPackage;
import com.brentvatne.react.ReactVideoPackage;
import com.lugg.ReactNativeConfig.ReactNativeConfigPackage;
import com.i18n.reactnativei18n.ReactNativeI18n;
import com.oblador.vectoricons.VectorIconsPackage;
Expand Down Expand Up @@ -47,8 +45,6 @@ protected List<ReactPackage> getPackages() {
new RNFirebaseNotificationsPackage(),
new RNVersionNumberPackage(),
new SplashScreenReactPackage(),
new ReactNativeAudioPackage(),
new ReactVideoPackage(),
new ReactNativeConfigPackage(),
new ReactNativeI18n(),
new VectorIconsPackage(),
Expand Down
4 changes: 0 additions & 4 deletions android/settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ include ':react-native-version-number'
project(':react-native-version-number').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-version-number/android')
include ':react-native-splash-screen'
project(':react-native-splash-screen').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-splash-screen/android')
include ':react-native-audio'
project(':react-native-audio').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-audio/android')
include ':react-native-video'
project(':react-native-video').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-video/android-exoplayer')
include ':react-native-config'
project(':react-native-config').projectDir = new File(rootProject.projectDir, '../node_modules/react-native-config/android')
include ':react-native-i18n'
Expand Down

0 comments on commit 0f795fa

Please sign in to comment.