fixed the time logic #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarianRushworth
approved these changes
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The start and finish hours/minutes/seconds were being subtracted from each other.
"finishSeconds - startSeconds"
And then I combined that into a string again and send it to the backend.
This would create times like 00:10:-40
Which is not what we want for obvious reasons.
Solution
I split up the time strings in start and finish and turn each string number into an integer.
Then I turn all numbers into seconds and add those together.
So 10 hours will become 10h * 3600s = 36000 seconds.. etc.
After that I can subtract one from the other and use calculations to turn the time that was used back into hours, minutes and seconds.
Which are then send to the backend, together with the rest again.