Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

creating our work section #40

Merged
merged 7 commits into from
May 9, 2020

Conversation

rajitha1998
Copy link
Member

@rajitha1998 rajitha1998 commented Apr 18, 2020

Fixes #20

Proposed Changes

  • Creating project cards
  • Setting the number of cards based on screen size
  • Switch card functionality
  • Project pop up cards
  • Mobile responsiveness

Screenshots

Video-4-25-2020-10-57-48-PM

@rajitha1998
Copy link
Member Author

Build failing because of this issue in is-promise 😞@janethavi @hasalfernando @nandulaperera @Purushothh

@hasalfernando
Copy link
Contributor

@rajitha1998 seems the issue isn't resolved yet. Let's wait for it to be resolved. However, the issue you mentioned isn't the active one. It is currently closed. This is the active issue thread.

@rajitha1998 rajitha1998 changed the title creating our work section (work in progress) creating our work section May 9, 2020
@rajitha1998 rajitha1998 marked this pull request as ready for review May 9, 2020 16:33
Copy link
Contributor

@nandulaperera nandulaperera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rajitha1998

@rajitha1998 rajitha1998 force-pushed the ourWork branch 2 times, most recently from aa60129 to 01b6c98 Compare May 9, 2020 16:53
@rajitha1998 rajitha1998 requested a review from janethavi May 9, 2020 16:53
Copy link
Contributor

@hasalfernando hasalfernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @rajitha1998

I found some things that needs to be adjusted in the project cards.

Cake-a-licious Website card

Change the name Codejunction to "codeJunction".

Ajith motors Entry System card

Change "according to the type of account(staff/admin)" to "according to the type of account (staff/admin)".

Fhix45 card

Remove the first sentence "This is one of the projects which was undertaken from codeJunction".

CodeJunction Website card

Change the name "CodeJunction" to "codeJunction" in both the title and the description.

Shall we update these changes?

src/app/components/components.component.ts Outdated Show resolved Hide resolved
src/app/components/our-work/our-work.component.html Outdated Show resolved Hide resolved
src/assets/json/projects.json Outdated Show resolved Hide resolved
@janethavi
Copy link
Contributor

Great work @rajitha1998! Nicely done🚀

Copy link
Contributor

@hasalfernando hasalfernando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @rajitha1998 Nice work!

@hasalfernando hasalfernando merged commit 57259dc into codeJunctionTeam:master May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create "Our work" section
4 participants