-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Docker compose only deployment #127
Labels
enhancement
New feature or request
reviewer comment
feedback from manuscript reviewers, should be prioritized
Milestone
Comments
epierotti3
added
the
reviewer comment
feedback from manuscript reviewers, should be prioritized
label
Apr 5, 2023
@feydan Does the org have a docker registry? |
There are two remaining items on this: |
shollingsworth
pushed a commit
that referenced
this issue
May 12, 2023
All fixes have been implemented. Closing issue. |
github-project-automation
bot
moved this from Needs Review/Questions
to Done
in TrashAI
May 12, 2023
shollingsworth
added a commit
that referenced
this issue
May 12, 2023
shollingsworth
added a commit
that referenced
this issue
May 12, 2023
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
reviewer comment
feedback from manuscript reviewers, should be prioritized
Guidelines
Description
Reviewer said: you directly build in the docker-compose file, so people need to clone the repository. If you would upload a pre-compiled container people could just download a docker-compose file and just run it from there. The container would be downloaded automatically from the repository and started.
Also your localdev really is an local development option and is not targeted for deployment. My idea was just to build one lean container which just serves the frontend so people can quickly run it on their desktop machines with docker desktop or on a local server with docker.
A simple Dockerfile could look like this:
FROM node:16.12.0 as builder
COPY . .
RUN yarn
RUN yarn build
FROM nginx:1.23.3
COPY --from=builder dist /usr/share/nginx/html
inside the frontend dir. This would just create an nginx based container with the frontend copied as static files into its public directory.
Problem
We may not need people to clone the whole repo.
Proposed Solution
Perhaps people could just use a single docker-compose file and we push everything to a docker container.
Alternatives Considered
Expect people to clone the whole repo.
The text was updated successfully, but these errors were encountered: