Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Docker compose only deployment #127

Closed
1 task done
wincowgerDEV opened this issue Mar 7, 2023 · 3 comments · Fixed by #157
Closed
1 task done

[Feature]: Docker compose only deployment #127

wincowgerDEV opened this issue Mar 7, 2023 · 3 comments · Fixed by #157
Labels
enhancement New feature or request reviewer comment feedback from manuscript reviewers, should be prioritized

Comments

@wincowgerDEV
Copy link
Collaborator

Guidelines

  • I agree to follow this project's Contributing Guidelines.

Description

Reviewer said: you directly build in the docker-compose file, so people need to clone the repository. If you would upload a pre-compiled container people could just download a docker-compose file and just run it from there. The container would be downloaded automatically from the repository and started.

Also your localdev really is an local development option and is not targeted for deployment. My idea was just to build one lean container which just serves the frontend so people can quickly run it on their desktop machines with docker desktop or on a local server with docker.

A simple Dockerfile could look like this:

FROM node:16.12.0 as builder
COPY . .
RUN yarn
RUN yarn build

FROM nginx:1.23.3
COPY --from=builder dist /usr/share/nginx/html
inside the frontend dir. This would just create an nginx based container with the frontend copied as static files into its public directory.

Problem

We may not need people to clone the whole repo.

Proposed Solution

Perhaps people could just use a single docker-compose file and we push everything to a docker container.

Alternatives Considered

Expect people to clone the whole repo.

@wincowgerDEV wincowgerDEV added the enhancement New feature or request label Mar 7, 2023
@epierotti3 epierotti3 added this to the Complete Manuscript milestone Apr 5, 2023
@epierotti3 epierotti3 moved this to To-Do in TrashAI Apr 5, 2023
@epierotti3 epierotti3 added the reviewer comment feedback from manuscript reviewers, should be prioritized label Apr 5, 2023
@shollingsworth
Copy link
Collaborator

@feydan Does the org have a docker registry?

@lovejavaee lovejavaee moved this from To-Do to In Progress in TrashAI May 4, 2023
@lovejavaee lovejavaee linked a pull request May 10, 2023 that will close this issue
@lovejavaee lovejavaee moved this from In Progress to Needs Review/Questions in TrashAI May 10, 2023
@shollingsworth
Copy link
Collaborator

There are two remaining items on this:
1.) pushing to docker registry during frontend build
2.) Fix the google api key during build process
3.) update README to reflect changes, remove uneeded localdev pieces because backend isn't being called right now.

@shollingsworth
Copy link
Collaborator

All fixes have been implemented. Closing issue.

@github-project-automation github-project-automation bot moved this from Needs Review/Questions to Done in TrashAI May 12, 2023
shollingsworth added a commit that referenced this issue May 12, 2023
* Fixes #127 - removed unnecessary backend components, added docker run to README

* Addresses #107 - Added other web server deployment to README based on public docker image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reviewer comment feedback from manuscript reviewers, should be prioritized
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants