Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add search to query string on submit in location mode #394

Conversation

joshreisner
Copy link
Contributor

closes #383

Copy link

netlify bot commented Jun 29, 2024

Deploy Preview for tsml-ui ready!

Name Link
🔨 Latest commit ec7ad43
🔍 Latest deploy log https://app.netlify.com/sites/tsml-ui/deploys/66f77365f3372d0008f21ce7
😎 Deploy Preview https://deploy-preview-394--tsml-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

…-string-doesnt-add-the-search-parameter-to-the-url
Copy link
Collaborator

@gkovats gkovats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine, though not 100% clear what Search near location is supposed to do.

…-string-doesnt-add-the-search-parameter-to-the-url
@joshreisner joshreisner merged commit 5bf4d0a into main Sep 28, 2024
6 checks passed
@joshreisner joshreisner deleted the 383-when-searching-near-a-location-the-query-string-doesnt-add-the-search-parameter-to-the-url branch September 28, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when searching near a location, the query string doesn't add the search parameter to the url
2 participants