Prevent issues with ACF time picker #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mark Chouinard <[email protected]>
$title undefined Signed-off-by: Mark Chouinard <[email protected]>
Signed-off-by: Mark Chouinard <[email protected]>
Signed-off-by: Mark Chouinard <[email protected]>
Signed-off-by: Mark Chouinard <[email protected]>
joshreisner
reviewed
Apr 24, 2020
joshreisner
reviewed
Apr 24, 2020
Signed-off-by: Mark Chouinard <[email protected]>
|
Looks good to me, thanks @machouinard ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooking tsml_assets() to admin_print_scripts allows us to check $post_type and only enqueue tsml assets for tsml_meeting post type. Appears to not negatively affect other calls to tsml_assets().
Also:
Prevent PHP undefined index notice.
Use $group->post_title instead of undefined $title for ajax tokens.