Added post information to feedback email #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds like a good change, of course I'm biased! :) Congrats to @mrlynn on his first open source project pull request! |
|
Hey yall, sorry I didn't see this! I need to check on my notifications settings. |
|
I can't figure out how to turn pull request notification emails on, so lmk if you make any more, and please make as many as you want. I've committed 2.5.2 to Wordpress with this change in it. |
|
Hey @joshreisner! I believe you just need to WATCH the project; I'm guessing you're not getting notified since it is within the "intergroup" group rather than your personal space. Mike and I are coming down to NAATW in November; I'm very much looking forward to meeting you! |
|
Oh that's great to hear, looking forward to meeting you too @FlipperPA. |
joshreisner
added a commit
that referenced
this pull request
Oct 11, 2017
Merge pull request #1 from meeting-guide/master
tech2serve
pushed a commit
that referenced
this pull request
Oct 26, 2020
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added address, city, state, zip to the feedback email. This is because the url that is placed at the bottom of the email refers to a post id which changes for us nightly as we re-import meetings from our source database.