Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only allow pnpm as the package manager for the project #1078

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

devsargam
Copy link
Collaborator

PR Fixes:

  • Only allow pnpm as the package manager in the project
  • Remove other unwanted lock files: package-lock.json & yarn.lock

Screenshots

When using yarn

When using npm

There's a bug in npm cli which runs preinstall hook after the installation so we don't get a good error message like when using yarn but gets the job done

ref: npm/cli#2660 (comment)

cc @hkirat @siinghd

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue

@siinghd
Copy link
Collaborator

siinghd commented Aug 29, 2024

@devsargam thank yo usir

@siinghd siinghd merged commit cc0d5fb into code100x:main Aug 29, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants