Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CC0029 should not be reported for Dispose(bool) #107

Closed
sharwell opened this issue Dec 3, 2014 · 2 comments
Closed

CC0029 should not be reported for Dispose(bool) #107

sharwell opened this issue Dec 3, 2014 · 2 comments
Assignees
@ElemarJR
Labels
3 - Done analyzer bug C#

Comments

@sharwell
Copy link
Contributor

sharwell commented Dec 3, 2014

Currently CC0029 is reported if Dispose(bool) does not contain a call to GC.SuppressFinalize. This is not correct; the call to GC.SuppressFinalize should be in the method which implements IDisposable.Dispose() (which may be an explicit implementation of the interface method).

This is a sub-task of #95.
@giggio
Copy link
Member

giggio commented Dec 3, 2014

@israelaece please verify.

@giggio
Copy link
Member

giggio commented Jan 17, 2015

Bug confirmed.

giggio added a commit that referenced this issue Apr 23, 2015
@giggio
Merge pull request #325 from ElemarJR/MoreFixesToCC0029
b66ec13 
More fixes to cc0029, closes #95 (aggregate task for cc0029)

also closes #110, closes #107 (subtasks)
jwooley pushed a commit to jwooley/code-cracker that referenced this issue Sep 14, 2015
@ElemarJR @jwooley
Supporting some types with private constructores (closes code-cracker…
9126772 
…#107, closes code-cracker#95)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ElemarJR ElemarJR

Labels
3 - Done analyzer bug C#
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ElemarJR @giggio @sharwell